Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix root-project support for Angular #13534

Merged
merged 2 commits into from Dec 1, 2022

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Dec 1, 2022
@vercel
Copy link

vercel bot commented Dec 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 1, 2022 at 0:47AM (UTC)

@@ -506,6 +506,76 @@ export function tslibC(): string {
expect(libEslint.overrides[1].extends).toBeUndefined();
expect(libEslint.overrides[1].extends).toBeUndefined();
});

it('(Angular standalone) should set root project config to app and e2e app and migrate when another lib is added', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meeroslav Standalone means something different in angular. (Standalone components and APIs etc) This would probably be better titled something like Angular root-project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a test in the linter e2e and matches our preset name so I would leave this as is, but I'll rename the PR.

@meeroslav meeroslav changed the title fix(angular): fix standalone support for angular fix(angular): fix root-project support for Angular Dec 1, 2022
@meeroslav meeroslav merged commit 22e70d6 into nrwl:master Dec 1, 2022
@meeroslav meeroslav deleted the fix-angular-standalone-linter branch March 14, 2023 22:17
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants