Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): remove extraneous logs from @nrwl/vite:build executor #13479

Merged
merged 1 commit into from Nov 29, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

There are extraneous logs when building vite apps and libs.

~/p/t/node-ipc-test (main|✚4…) $ nx build app1

> nx run app1:build:production  [local cache]


>  NX  Vite build starting ...

vite v3.2.4 building for production...
✓ 36 modules transformed.
../../dist/apps/app1/index.html                  0.46 KiB
../../dist/apps/app1/assets/index.ccdffbe4.js    179.19 KiB / gzip: 56.61 KiB

>  NX  Vite build finished ...


>  NX  Vite files available in dist/apps/app1


 ——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Successfully ran target build for project app1 (25ms)

Expected Behavior

The output is pretty much the same as vite

~/p/t/node-ipc-test (main|✚4…) $ nx build app1

> nx run app1:build:production

vite v3.2.4 building for production...
✓ 36 modules transformed.
../../dist/apps/app1/index.html                  0.46 KiB
../../dist/apps/app1/assets/index.ccdffbe4.js    179.19 KiB / gzip: 56.61 KiB

 ——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Successfully ran target build for project app1 (2s)

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 29, 2022 at 7:53PM (UTC)

@FrozenPandaz FrozenPandaz merged commit 9d5a45d into nrwl:master Nov 29, 2022
@FrozenPandaz FrozenPandaz deleted the rm-logs branch November 29, 2022 20:15
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant