Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): place files in the right folders for React Vite apps #13443

Merged
merged 1 commit into from Nov 28, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 28, 2022

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 28, 2022 at 3:09PM (UTC)

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Yes, the styles too!! Forgot about that! :)

Tests fail, I think it may be the snapshots?

@jaysoo jaysoo force-pushed the fix/vite-assets-in-public-dir branch from 88bcf43 to 37da1ed Compare November 28, 2022 15:09
@jaysoo jaysoo enabled auto-merge (squash) November 28, 2022 15:30
@jaysoo jaysoo merged commit 8103290 into nrwl:master Nov 28, 2022
@jaysoo jaysoo deleted the fix/vite-assets-in-public-dir branch November 28, 2022 15:36
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants