Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): if bundler is vite unitTestRunner is vitest #13436

Merged
merged 1 commit into from Nov 28, 2022

Conversation

mandarini
Copy link
Member

If bundler: 'vite' for React make sure to set unitTestRunner to vitest (as is done in the nrwl/web:app generator). If unitTestRunner is not set to vitest, it's set to jest by default, and the nrwl/react:app generator will attempt to generate jest files, but it will not be able to do so, since the test target will already be set to vite and the generator will exit with error already has a test architect option.

@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 28, 2022 at 11:13AM (UTC)

@mandarini mandarini self-assigned this Nov 28, 2022
@mandarini mandarini merged commit 871f618 into nrwl:master Nov 28, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant