Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): set rootDir to the project root when bundling with rollup #13407

Merged
merged 1 commit into from Nov 25, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 25, 2022

  • Fixes errors when *.ts files exist outside of source root

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 25, 2022 at 3:09PM (UTC)

@jaysoo jaysoo marked this pull request as ready for review November 25, 2022 14:23
@jaysoo jaysoo enabled auto-merge (squash) November 25, 2022 14:26
@jaysoo jaysoo force-pushed the fix/rollup-root-dir branch 2 times, most recently from b6689b1 to db719db Compare November 25, 2022 15:03
- Fixes errors when *.ts files exist outside of source root
@jaysoo jaysoo merged commit 5aaba51 into nrwl:master Nov 25, 2022
@jaysoo jaysoo deleted the fix/rollup-root-dir branch November 25, 2022 15:35
@jaknas
Copy link

jaknas commented Feb 14, 2023

@jaysoo FYI this change caused a regression where declaration files are now under: dist/src/lib while previously they were in dist/lib

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants