Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): port should be added to serve-ssr for remote #13399

Merged
merged 1 commit into from Nov 25, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 25, 2022

Current Behavior

The port is not being added to serve-ssr options when generating a remote.

Expected Behavior

The port should be added to serve-ssr to ensure it gets served correctly and can be found by the host.

@Coly010 Coly010 self-assigned this Nov 25, 2022
@vercel
Copy link

vercel bot commented Nov 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 25, 2022 at 0:14AM (UTC)

@Coly010 Coly010 merged commit 1a23203 into nrwl:master Nov 25, 2022
@Coly010 Coly010 deleted the angular/remote-port-ssr branch November 25, 2022 12:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant