Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): check validity of Nx context in withNx plugin #13358

Merged
merged 1 commit into from Nov 23, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 23, 2022

Current Behavior

If users use next-compose-plugins then withNx gets the wrong context object and errors out.

Expected Behavior

Using next-compose-plugins should work.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 23, 2022 at 4:09PM (UTC)

@jaysoo jaysoo enabled auto-merge (squash) November 23, 2022 16:11
@jaysoo jaysoo merged commit dc16468 into nrwl:master Nov 23, 2022
@jaysoo jaysoo deleted the issue/13143 branch November 23, 2022 16:36
FrozenPandaz pushed a commit that referenced this pull request Nov 28, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant