Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): ensure project has eslint available before adding lint checks for migrations.json #13327

Merged
merged 1 commit into from Nov 22, 2022

Conversation

Elyahou
Copy link
Contributor

@Elyahou Elyahou commented Nov 22, 2022

Current Behavior

When generating a migration in a repository/project that don't have eslint target, it give this error:

>  NX   getEsLintOptions is not a function or its return value is not iterable

Expected Behavior

The migration is generated without adding lint check to migrations.json file

Fixes #13326

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 22, 2022 at 4:44PM (UTC)

@AgentEnder AgentEnder changed the title fix(linter): Check eslint target existence before trying to add migration.json checks fix(nx-plugin): ensure project has eslint available before adding lint checks for migrations.json Nov 22, 2022
@AgentEnder AgentEnder merged commit 90f2791 into nrwl:master Nov 22, 2022
FrozenPandaz pushed a commit that referenced this pull request Nov 28, 2022
…t checks for migrations.json(#13327)

Fixes #13326

(cherry picked from commit 90f2791)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when generating migration in a repo/project without lint plugin enabled
2 participants