Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix Karma test runner config #13293

Merged
merged 2 commits into from Nov 23, 2022
Merged

Conversation

DominikPieper
Copy link
Contributor

ISSUES CLOSED: #13291

I'm not sure this is the right solution for the error. See #13291.
The mentioned polyfills.ts isn't there. If it is needed, maybe this should be added or the lines removed

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #13291

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 23, 2022 at 11:06AM (UTC)

@Coly010
Copy link
Contributor

Coly010 commented Nov 23, 2022

Thanks for the PR @DominikPieper !

I added some changes to ensure we continue to support existing applications that use old-style polyfills paths.

@Coly010 Coly010 merged commit e3d8b2c into nrwl:master Nov 23, 2022
@DominikPieper
Copy link
Contributor Author

Great :-) Thanks. Wasn't completely sure what was needed cause I don't used Karma for years

FrozenPandaz pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: Colum Ferry <cferry09@gmail.com>
(cherry picked from commit e3d8b2c)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With Nx 15.2.x using Karma for @nrwl/angular is broken
2 participants