Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): use the browserTarget to calculate project deps for buildable libs support in the dev server #13275

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

The webpack-dev-server builder, when handling the incremental build scenario, is not using the browserTarget name to calculate the buildable project dependencies. This causes the builder to not collect any buildable libraries and build them from the source even when the buildLibsFromSource option is set to false.

This is a regression introduced in #12924 where the following was missed https://github.com/nrwl/nx/pull/12924/files#diff-39a45d5a12bd4b48ebc0871fab97966eab51e70137d4e1d48df18ee5171b5da2L83.

Expected Behavior

The webpack-dev-server builder when handling the incremental build scenario, should use the browserTarget name to calculate the buildable project dependencies.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Nov 20, 2022
@vercel
Copy link

vercel bot commented Nov 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 20, 2022 at 0:56AM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit 1830669 into nrwl:master Nov 20, 2022
@leosvelperez leosvelperez deleted the angular/fix-dev-server-build-lib-target branch November 20, 2022 19:43
FrozenPandaz pushed a commit that referenced this pull request Nov 28, 2022
…ldable libs support in the dev server (#13275)

(cherry picked from commit 1830669)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants