Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): should support filereplacements for apps that already have them #13247

Merged
merged 1 commit into from Nov 18, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 18, 2022

Current Behavior

People may need to run setup-ssr on an app they have migrated along older versions of angular which still has fileReplacments

Expected Behavior

We should support this use case

@Coly010 Coly010 self-assigned this Nov 18, 2022
@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 18, 2022 at 0:03AM (UTC)

@Coly010 Coly010 enabled auto-merge (squash) November 18, 2022 12:02
@Coly010 Coly010 merged commit b4fb074 into nrwl:master Nov 18, 2022
@Coly010 Coly010 deleted the angular/ssr-if-old-app-support-envs branch November 18, 2022 12:21
FrozenPandaz pushed a commit that referenced this pull request Nov 18, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant