Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): set project names using a blog instead of project graph #13202

Merged
merged 1 commit into from Nov 16, 2022

Conversation

vsavkin
Copy link
Member

@vsavkin vsavkin commented Nov 16, 2022

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ❌ Failed (Inspect) Nov 16, 2022 at 3:36PM (UTC)

const projectJsons = projectFiles.filter((f) => f.endsWith('project.json'));

for (let f of projectJsons) {
const projectJson = readJsonFile(f);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure these are not tree operations.

You can use updateJson for this.

@vsavkin vsavkin force-pushed the fix-set-project-names-migration branch from 6b30a2d to b0907ec Compare November 16, 2022 15:33
@vsavkin vsavkin force-pushed the fix-set-project-names-migration branch from b0907ec to 3268018 Compare November 16, 2022 15:34
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants