Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): add babel-jest transform options for react libraries #13175

Merged
merged 1 commit into from Nov 16, 2022

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

when creating a react library the transform options are not set like they are in a react app causing issues where babel transforms won't be applied as expected; therefore, looking like it doesn't work when there just aren't presets for the transform to apply.

Expected Behavior

preset is set when making a new react lib

Related Issue(s)

Fixes #

@barbados-clemens barbados-clemens self-assigned this Nov 15, 2022
@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 15, 2022 at 2:51PM (UTC)

@jaysoo jaysoo merged commit 620f6a6 into nrwl:master Nov 16, 2022
@barbados-clemens barbados-clemens deleted the fix/babel-jest-preset branch December 2, 2022 14:24
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants