Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): handle yarn workspace packages when pruning #13170

Merged
merged 2 commits into from Nov 16, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Nov 15, 2022

Add missing pruning functionality:

  • Prune NPM
    • Pruning V1 (workaround in place)
    • Pruning V2 [Done in the previous PR]
    • Pruning V3 [Done in the previous PR]
    • Root project name pruning [Done in the previous PR]
    • Handle peer dependencies [Done in the previous PR]
  • Prune Yarn
    • Pruning Classic [Done in the previous PR]
    • Pruning Berry [Done in the previous PR]
    • Workspace projects pruning
  • Prune Pnpm
    • Pruning Pnpm [Done in the previous PR]
    • Lock file meta pruning
  • Solve hashing [Done in the previous PR]

Current Behavior

Expected Behavior

Related Issue(s)

Related to #9761

@meeroslav meeroslav added the scope: core core nx functionality label Nov 15, 2022
@meeroslav meeroslav self-assigned this Nov 15, 2022
@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 10:42AM (UTC)

@meeroslav meeroslav marked this pull request as ready for review November 16, 2022 10:37
@meeroslav meeroslav merged commit 45cba68 into nrwl:master Nov 16, 2022
@meeroslav meeroslav deleted the prune-yarn-lock-workspaces branch November 21, 2022 14:00
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant