Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): local imports in webpack-dev-server custom config #13156

Merged
merged 1 commit into from Nov 18, 2022

Conversation

Michsior14
Copy link
Contributor

@Michsior14 Michsior14 commented Nov 14, 2022

Fixes the implementation of webpack-dev-server to allow imports of local libraries in custom webpack config typescript files. This aligns the behavior with the webpack-browser and webpack-server builders.

Current Behavior

After the cleanup story #12924 (this change), custom webpack files lost the possibility to import local libraries. Each serve command ends up with error being thrown regarding unresolved dependencies while build works fine.

Expected Behavior

The serve command works in the same way as build and allow referencing local libraries.

Related Issue(s)

Fixes #13233

Fixes the implementation of webpack-dev-server to allow imports of
local buildable libraries in custom webpack config typescript files.
This aligns the behavior with the webpack-browser and webpack-server
builders.
@vercel
Copy link

vercel bot commented Nov 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 14, 2022 at 4:56PM (UTC)

@Michsior14
Copy link
Contributor Author

Michsior14 commented Nov 14, 2022

Not sure, but I think it should also default to options.tsConfig if undefined in case of buildable libraries.

@Coly010 Coly010 self-assigned this Nov 18, 2022
@Coly010
Copy link
Contributor

Coly010 commented Nov 18, 2022

LGTM! 🎉 Thanks for this!

@Coly010 Coly010 merged commit e971ffb into nrwl:master Nov 18, 2022
FrozenPandaz pushed a commit that referenced this pull request Nov 18, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/angular:webpack-dev-server executor fails with local imports in webpack config
2 participants