Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): call normalizePath on generated importPath #13037

Merged
merged 1 commit into from Nov 7, 2022

Conversation

janwiebedroid
Copy link
Contributor

Used normalizePath to replace the windows style path with a unix style path.

Current Behavior

When running nx build on a project that has a dependency to another project the paths are generated like this: import { child } from "....\child\src";

Expected Behavior

I expect that the paths are generated like: import { child } from "../../child/src"; or import { child } from "..\..\child\src";

Related Issue(s)

#13011

Fixes #13011

normalizePath is needed to replace the windows style path with a unix style path.

Fixes nrwl#13011
@vercel
Copy link

vercel bot commented Nov 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 7, 2022 at 7:08PM (UTC)

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 2818f2e into nrwl:master Nov 7, 2022
FrozenPandaz pushed a commit that referenced this pull request Nov 8, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated js code uses '\' in import when configuring external projects.
2 participants