Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): patch migration from @nrwl/node:package to @nrwl/js:tsc to rename srcRootForCompilationRoot option to rootDir #12999

Merged
merged 1 commit into from Nov 4, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 4, 2022

This fixes an issue with the previous migration where srcRootForCompilationRoot was not renamed to rootDir. Should also be cherry-picked to 14.x version.

Current Behavior

Users run into errors after migration and have to manually update options per-project.

Expected Behavior

Nx migration automatically update options.

Related Issue(s)

Fixes #

…ename srcRootForCompilationRoot option to rootDir
@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 4, 2022 at 5:10PM (UTC)

@jaysoo jaysoo merged commit 9cbf9bf into nrwl:master Nov 4, 2022
FrozenPandaz pushed a commit that referenced this pull request Nov 4, 2022
…ename srcRootForCompilationRoot option to rootDir (#12999)

(cherry picked from commit 9cbf9bf)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant