Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): improve performance of showing/hiding directories of projects #12998

Merged

Conversation

philipjfulcher
Copy link
Collaborator

Current Behavior

  • Showing or hiding a directory of projects sends an individual event for each project added or hidden, resulting in a graph re-render for each one.

Expected Behavior

  • Showing or hiding a directory of projects sends a single events which causes a single graph re-render

@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 3:08PM (UTC)

@philipjfulcher philipjfulcher self-assigned this Nov 4, 2022
@philipjfulcher philipjfulcher enabled auto-merge (squash) November 4, 2022 15:05
@philipjfulcher philipjfulcher merged commit 305f694 into nrwl:master Nov 4, 2022
FrozenPandaz pushed a commit that referenced this pull request Nov 4, 2022
@philipjfulcher philipjfulcher deleted the graph-hide-all-directory-perf branch November 27, 2022 22:35
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant