Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve external node dependency mapping #12996

Merged
merged 5 commits into from Nov 7, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Nov 4, 2022

Current Behavior

External node dependencies mapping uses semver to match first version that satisfies the range, but this might not always be accurate.

Expected Behavior

External node dependencies mapping should use package manager lock file internals to track dependencies:

  • full path (node_modules/parent/node_modules/child) for npm
  • exact dependency version for pnpm
  • dependency key (child@^1.2.3) for yarn

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Nov 4, 2022
@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 9:58AM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant