Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): schedule tasks with the most tasks that depend on it first #12967

Merged
merged 1 commit into from Nov 7, 2022

Conversation

skrtheboss
Copy link
Contributor

Current Behavior

Tasks are scheduled by its dependency order.

Expected Behavior

Tasks should be scheduled by how many other tasks depend on it, to avoid bottlenecks.

For our use case it produces 2-5% faster builds. depending on the dependency order and parallel count.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 1:54PM (UTC)

@skrtheboss skrtheboss changed the title fix(core): schedule tasks with the most dependent tasks first fix(core): schedule tasks with the most tasks that depend on it first Nov 3, 2022
Tasks should be scheduled by how many other tasks depend on it,
to avoid bottlenecks.
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 59ed6f1 into nrwl:master Nov 7, 2022
FrozenPandaz pushed a commit that referenced this pull request Nov 7, 2022
@skrtheboss skrtheboss deleted the fix/improove-task-scheduler branch December 22, 2022 08:01
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants