Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): add option to override outputPath for file-server #12941

Merged

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

when trying to use file-server with an executor that does not have an outputPath property (i.e. storybook) you are unable to serve the artifacts with file-server

Expected Behavior

be able to manually override the outputPath to allow other executors to use file server

Related Issue(s)

Fixes #

@barbados-clemens barbados-clemens self-assigned this Nov 2, 2022
@vercel
Copy link

vercel bot commented Nov 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 4:28PM (UTC)

@barbados-clemens barbados-clemens changed the title fix(web): add option for override outputPath for file-server fix(web): add option to override outputPath for file-server Nov 2, 2022
@AgentEnder AgentEnder enabled auto-merge (squash) November 2, 2022 16:30
@AgentEnder AgentEnder merged commit 3f9909a into nrwl:master Nov 2, 2022
@barbados-clemens barbados-clemens deleted the fix/file-server-output-path branch November 2, 2022 16:59
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants