Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): provide better error messages around component test --build-target #12886

Merged

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

when error happens in finding the build target for component testing they aren't helpful into why a build target won't work or why the generator didn't find a build target

Expected Behavior

More helpful errors when providing a build target that's invalid

Related Issue(s)

Fixes #12844

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Oct 28, 2022
@barbados-clemens barbados-clemens self-assigned this Oct 28, 2022
@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 2, 2022 at 11:03PM (UTC)

@barbados-clemens barbados-clemens force-pushed the fix/cy-ct-generator-error-messages branch from c96817f to 7126888 Compare November 2, 2022 23:02
@barbados-clemens barbados-clemens marked this pull request as ready for review November 2, 2022 23:03
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@AgentEnder AgentEnder merged commit 39518e3 into nrwl:master Nov 4, 2022
@barbados-clemens barbados-clemens deleted the fix/cy-ct-generator-error-messages branch November 5, 2022 17:05
FrozenPandaz pushed a commit that referenced this pull request Nov 7, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot setup cypress component testing for a lib or app via the generator
2 participants