Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): handle path offsets for angular component testing #12863

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

style preprocessor options where not properly offset when using angular ct.

Expected Behavior

style preprocessor paths are properly offset to prevent compile errors.

Related Issue(s)

Fixes #12758

@barbados-clemens barbados-clemens self-assigned this Oct 27, 2022
@vercel
Copy link

vercel bot commented Oct 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 27, 2022 at 10:22PM (UTC)

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Oct 27, 2022
@barbados-clemens barbados-clemens marked this pull request as ready for review November 4, 2022 16:37
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@barbados-clemens barbados-clemens merged commit 5a137d0 into nrwl:master Nov 4, 2022
@barbados-clemens barbados-clemens deleted the fix/ng-ct-style-preprocessor-paths branch November 4, 2022 16:43
FrozenPandaz pushed a commit that referenced this pull request Nov 4, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress component testing with Angular results in SassError
2 participants