Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo): fixing broken tutorial link #12753

Merged
merged 1 commit into from Oct 24, 2022

Conversation

ZackDeRose
Copy link
Member

Current Behavior

The welcome page (when serving after initially creating an application) for expo links to an incorrect link for the docs

Expected Behavior

The welcome page has the correct link.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 24, 2022 at 4:22PM (UTC)

@ZackDeRose
Copy link
Member Author

Hey @xiongemi, it looks like the expo e2e tests are failing in this PR, and looks like they're also failing in the master branch. Is this known?

@xiongemi
Copy link
Collaborator

Hey @xiongemi, it looks like the expo e2e tests are failing in this PR, and looks like they're also failing in the master branch. Is this known?
the error is npm ERR! 404 Not Found - GET http://localhost:4872/@types%2fwebpack-sources - no such package available. it could not install the library @types/webpack-sources.
i think it is just one off case. could you just rebase and run the ci test again?

@bcabanes bcabanes merged commit 5837715 into nrwl:master Oct 24, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants