feat(nxdev): redirects to send legacy tutorial links to new locations

[ZackDeRose]

Current Behavior

Links to legacy docs (e.g. https://nx.dev/react-tutorial/01-create-application) lead to a 404 page.

Expected Behavior

User navigating to any old link get redirected to step 1 of the new tutorial (https://nx.dev/react-tutorial/1-code-generation).

Related Issue(s)

Fixes #

[nx-cloud-staging]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 686aba5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=e2e --base=67376209ddb1681481635e09836f9e705b9d2512 --head=686aba5ba610e53ecea3079a94850243144217d5 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1
• nx affected --target=build --base=67376209ddb1681481635e09836f9e705b9d2512 --head=686aba5ba610e53ecea3079a94850243144217d5 --parallel=3
• nx-cloud record -- yarn depcheck
• nx affected --target=test --base=67376209ddb1681481635e09836f9e705b9d2512 --head=686aba5ba610e53ecea3079a94850243144217d5 --parallel=1
• nx affected --target=lint --base=67376209ddb1681481635e09836f9e705b9d2512 --head=686aba5ba610e53ecea3079a94850243144217d5 --parallel=3
• nx-cloud record -- yarn nx workspace-lint
• nx-cloud record -- yarn check-lock-files
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn nx format:check --base=67376209ddb1681481635e09836f9e705b9d2512 --head=686aba5ba610e53ecea3079a94850243144217d5
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn documentation
• nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Oct 22, 2022 at 2:57AM (UTC)

[ZackDeRose]

[still want to add tests for this; @bcabanes, can you let me know at what level we'd like to add these?]

[ZackDeRose]

Hey @bcabanes, as I mentioned, I'm looking to add some testing to these to ensure the redirects work as directed. I was going to opt into a set of e2e tests to assert the redirect actually works (see below), but happy to move that to some unit test if you prefer that strategy (or these would be too expensive)

describe('Tutorial redirects', () => {
  const redirects: {
    givenUrl: string;
    expectedDestination: string;
  }[] = [
    {
      givenUrl: '/react-tutorial/01-create-application',
      expectedDestination: '/react-tutorial/1-code-generation',
    },
    {
      givenUrl: '/react-tutorial/02-add-e2e-test',
      expectedDestination: '/react-tutorial/1-code-generation',
    },
    // ...
  ];
  for (const redirect of redirects) {
    testRedirect(redirect);
  }
});

function testRedirect({
  givenUrl,
  expectedDestination,
}: {
  givenUrl: string;
  expectedDestination: string;
}) {
  it(`"${givenUrl}" to ${expectedDestination}`, () => {
    cy.visit(givenUrl);
    cy.url().should('include', expectedDestination);
  });
}

[bcabanes]

@ZackDeRose Instead of adding 24 new E2E tests that will slow down the whole CI run, we could change these tests to unit tests making sure the redirect rules are declared and their values are correct (without hitting the website).

There are multiple things here:

1. moving the redirect rules into the /redirect-rules.config.js file
2. creating unit tests making sure these redirect rules are present and their values are correct.
3. removing the proposed regexps, we do not want a "catch-all" rule that would conflict with future paths.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.