Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): incorrect conditional to decide if package should be added #12749

Merged
merged 1 commit into from Oct 21, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 21, 2022

Current Behavior

The conditional to check if packages should be updated missed a use case allowing lower versions to be installed

Expected Behavior

The conditional to check if packages should be updates supports checking for lower package versions and resolves correctly

Related Issue(s)

Fixes #12666

@Coly010 Coly010 self-assigned this Oct 21, 2022
@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 5:49PM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx generator updates pinned dependencies to the default
2 participants