Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): support serving static remotes using tuple API #12658 #12691

Merged
merged 1 commit into from Oct 19, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 18, 2022

Current Behavior

Tuple API is supported as an option for providing URL of the remote app, however, the static remotes in the builder does not support that api.

Expected Behavior

module-federation-dev-server should support tuple API.

Related Issue(s)

Fixes #12658

@Coly010 Coly010 self-assigned this Oct 18, 2022
@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 18, 2022 at 6:15PM (UTC)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit d6285a5 into nrwl:master Oct 19, 2022
@Coly010 Coly010 deleted the angular/12658-tuple-remote-api branch October 19, 2022 17:53
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote entry tuples not supported?
2 participants