New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph): toggle visibility of all projects in a folder #12641
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6a840d6
to
0ffea24
Compare
0ffea24
to
d5b6707
Compare
d5b6707
to
e809695
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I especially appreciate the added e2e tests.
I like this addition. After talking with some other folks, we think the behavior for clicking the toggle button for a folder when some of the projects are already selected should change. It should add the rest of the projects, rather than deselect the currently selected projects.
I think your failing e2e task should pass after a rebase on master.
Let me know if you need any help. 😄
Adds a button next to the folder label to quickly show/hide all projects of that folder ISSUES CLOSED: nrwl#12640
I had some time today, so I made the change myself. Thanks again for your work! |
b869b71
to
2a047bc
Compare
Hey, I was on vacation last week. Thanks for taking the time to finish this, much appreciated! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Adds a button next to the folder label to quickly show/hide all projects of that folder.
Related Issue(s)
Fixes #12640