Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): toggle visibility of all projects in a folder #12641

Merged
merged 2 commits into from Nov 2, 2022

Conversation

alexciesielski
Copy link
Contributor

@alexciesielski alexciesielski commented Oct 15, 2022

Adds a button next to the folder label to quickly show/hide all projects of that folder.

image

Related Issue(s)

Fixes #12640

@vercel
Copy link

vercel bot commented Oct 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 9:19PM (UTC)

Copy link
Collaborator

@philipjfulcher philipjfulcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I especially appreciate the added e2e tests.

I like this addition. After talking with some other folks, we think the behavior for clicking the toggle button for a folder when some of the projects are already selected should change. It should add the rest of the projects, rather than deselect the currently selected projects.

I think your failing e2e task should pass after a rebase on master.

Let me know if you need any help. 😄

alexciesielski and others added 2 commits November 1, 2022 14:54
Adds a button next to the folder label to quickly show/hide all projects of that folder

ISSUES CLOSED: nrwl#12640
@philipjfulcher
Copy link
Collaborator

I had some time today, so I made the change myself. Thanks again for your work!

@alexciesielski
Copy link
Contributor Author

Hey, I was on vacation last week. Thanks for taking the time to finish this, much appreciated!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph: show/hide all projects of a given folder
2 participants