fix(core): catch rejected promises in convertNxExecutor #12627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
If an Nx executor when wrapped as an Angular builder, errors are not caught causing the builder to hang.
This is demonstrated in this repo: https://github.com/philipjfulcher/angular-builder-uncaught-rejection
After cloning and running
npm i
, trynpx nx allof-run-commands-fails app
to see the uncaught promise rejection error. The process will not close on its own.Expected Behavior
If an Nx executor when wrapped as an Angular builder, errors are caught and report failure successfully.