Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): handle different exports field shapes #12613

Merged
merged 1 commit into from Oct 15, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 14, 2022

The exports field in package.json can have string values instead of objects, this will break if the user sets this for the . export.

Current Behavior

If user has a string in exports like exports: './index.js' then our JS build fails.

Expected Behavior

Custom exports with string should work, same with exports: { '.': './index.js' }.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Oct 15, 2022 at 11:53AM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants