Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove warning for invalid outputs #12589

Merged
merged 1 commit into from Oct 13, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

There is a warning for the old version of outputs without {workspaceRoot}.

Expected Behavior

There is no warning for the old version of outputs without {workspaceRoot}. This warning will be added later.

Rationale

For plugins, there's no easy way to pick between the old output paths vs the new output paths with the {workspaceRoot}.

On older versions of Nx, adding {workspaceRoot} would be broken. On newer versions.. if I left the warning in... the old paths would trigger warnings...

Plugins can continue to generate the old paths.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 10:46PM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant