Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): swap default method for output capture #12535

Merged
merged 3 commits into from Oct 12, 2022
Merged

fix(core): swap default method for output capture #12535

merged 3 commits into from Oct 12, 2022

Conversation

AgentEnder
Copy link
Member

BREAKING CHANGE: Swaps from direct-nodejs to pipe for default output capture mechanism. Less accurate for executors that don't use child process, but still works for generic case. Previous behaviour still available through opt-in

@nx-cloud-staging
Copy link

nx-cloud-staging bot commented Oct 11, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1940a08. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Oct 11, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 9:55PM (UTC)

@AgentEnder
fix(core): swap default method for output capture
28ffe7a 
BREAKING CHANGE: Swaps from direct-nodejs to pipe for default output capture mechanism. Less accurate for executors that don't use child process, but still works for generic case. Previous behaviour still available through opt-in
@AgentEnder
chore(misc): apply migration
d3ffe3c
@AgentEnder AgentEnder force-pushed the chore/swap-default-output-capture-method branch from 833ef9d to d975d54 Compare October 11, 2022 23:01
@AgentEnder AgentEnder force-pushed the chore/swap-default-output-capture-method branch from d975d54 to d44c097 Compare October 12, 2022 14:00
@AgentEnder AgentEnder force-pushed the chore/swap-default-output-capture-method branch from d44c097 to 36e7a26 Compare October 12, 2022 14:09
@AgentEnder AgentEnder force-pushed the chore/swap-default-output-capture-method branch from 36e7a26 to c58a923 Compare October 12, 2022 14:51
@AgentEnder AgentEnder marked this pull request as ready for review October 12, 2022 16:17
FrozenPandaz
FrozenPandaz approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check these afterwards

packages/detox/src/executors/build/schema.json
@@ -1,4 +1,6 @@
{
"version": 2,
"outputCapture": "direct-nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiongemi The output capture might be wrong here.

packages/detox/src/executors/test/schema.json
@@ -1,4 +1,6 @@
{
"version": 2,
"outputCapture": "direct-nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiongemi The output capture might be wrong here

packages/esbuild/src/executors/esbuild/schema.json Outdated
"default": []
},
"format": {
"type": "array",
"description": "List of module formats to output. Defaults to matching format from tsconfig (e.g. CJS for CommonJS, and ESM otherwise).",
"description": "Set the output format(s).",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check this

packages/expo/src/executors/build/schema.json
@@ -1,4 +1,6 @@
{
"version": 2,
"outputCapture": "direct-nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiongemi Check the output capture of these executors as well

packages/js/src/executors/node/schema.json
@@ -1,4 +1,6 @@
{
"version": 2,
"outputCapture": "direct-nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if this prints correctly

packages/js/src/executors/swc/schema.json
@@ -1,4 +1,6 @@
{
"version": 2,
"outputCapture": "direct-nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaysoo Check this output capture

packages/node/src/executors/node/schema.json
@@ -1,4 +1,6 @@
{
"version": 2,
"outputCapture": "direct-nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output capture might be wrong here.

packages/react-native/src/executors/build-android/schema.json
@@ -1,4 +1,6 @@
{
"version": 2,
"outputCapture": "direct-nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiongemi These output captures might be wrong

packages/web/src/executors/file-server/schema.json
@@ -1,4 +1,6 @@
{
"version": 2,
"outputCapture": "direct-nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this output capture correct?

AgentEnder
AgentEnder commented Oct 12, 2022
View reviewed changes
Copy link
Member Author

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging for v15

@AgentEnder AgentEnder force-pushed the chore/swap-default-output-capture-method branch from c58a923 to 1940a08 Compare October 12, 2022 21:52
@AgentEnder AgentEnder enabled auto-merge (squash) October 12, 2022 21:52
@AgentEnder AgentEnder merged commit 8ab7f85 into nrwl:master Oct 12, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Assignees

@FrozenPandaz FrozenPandaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AgentEnder @FrozenPandaz