Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ng-add migration should set default project #12513

Merged
merged 2 commits into from Oct 11, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 11, 2022

Current Behavior

Migration doesn't set the default project

Expected Behavior

Migration should set the default project

Related Issue(s)

Fixes #12332

@Coly010 Coly010 self-assigned this Oct 11, 2022
@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 11, 2022 at 0:26AM (UTC)

@Coly010 Coly010 force-pushed the angular/set-default-on-migration branch 2 times, most recently from e849a2f to b4a43a7 Compare October 11, 2022 11:33
@Coly010 Coly010 force-pushed the angular/set-default-on-migration branch from b4a43a7 to 2c5064e Compare October 11, 2022 12:04
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
@Coly010 Coly010 force-pushed the angular/set-default-on-migration branch from c3235b1 to 264b582 Compare October 11, 2022 12:26
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit 66a0864 into nrwl:master Oct 11, 2022
@Coly010 Coly010 deleted the angular/set-default-on-migration branch October 11, 2022 14:28
FrozenPandaz pushed a commit that referenced this pull request Oct 11, 2022
* fix(angular): ng-add migration should set default project

* fix(angular): add pr suggestions

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
(cherry picked from commit 66a0864)
FrozenPandaz pushed a commit that referenced this pull request Oct 11, 2022
* fix(angular): ng-add migration should set default project

* fix(angular): add pr suggestions

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
(cherry picked from commit 66a0864)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting angular workspace to nrwl while preserving layout fails to set default project
2 participants