Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): do not use ngcc for new workspaces and projects #12386 #12504

Merged
merged 1 commit into from Oct 11, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 11, 2022

Current Behavior

We add a post install script to run ngcc to all new workspaces and to existing workspaces that are not using it when the angular init generator is called.

With Ivy being around for a while now, and most packages having migrated to use partial compilation, it makes more sense for people to intentionally add this themselves.

Related Issue(s)

Fixes #12386

@Coly010 Coly010 self-assigned this Oct 11, 2022
@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 8:58AM (UTC)

@Coly010 Coly010 force-pushed the angular/remove-ngcc-from-new branch from 19818ca to aa85986 Compare October 11, 2022 08:55
@Coly010 Coly010 merged commit 80a623e into nrwl:master Oct 11, 2022
@Coly010 Coly010 deleted the angular/remove-ngcc-from-new branch October 11, 2022 09:29
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating new @nrwl/angular:host application adds ngcc
1 participant