Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): inlined buildable libraries original output should not be re… #12483

Merged
merged 1 commit into from Oct 11, 2022

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Oct 10, 2022

…moved

Current Behavior

Buildable libraries' outputs are removed if they are inlined.

Expected Behavior

Buildable libraries' outputs should be be removed as they can still be used as cache/incremental build for other projects.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 11, 2022 at 3:53PM (UTC)

@nartc nartc force-pushed the fix/inline-buildable-libraries branch from 42ce197 to fa8996d Compare October 10, 2022 06:22
@nartc nartc marked this pull request as ready for review October 11, 2022 02:17
@nartc nartc force-pushed the fix/inline-buildable-libraries branch from fa8996d to e863438 Compare October 11, 2022 02:25
@nartc nartc force-pushed the fix/inline-buildable-libraries branch from e863438 to 65940e9 Compare October 11, 2022 15:53
@nartc nartc requested a review from jaysoo October 11, 2022 16:41
@nartc nartc merged commit b17893c into nrwl:master Oct 11, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants