feat(core): warn when falling back to angular cli for misc commands #12401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
juristr
reviewed
Oct 4, 2022
AgentEnder
force-pushed
the
feat/ng/warn-for-fallbacks
branch
from
152218d
to
ab8650d
Compare
FrozenPandaz
requested changes
Oct 5, 2022
packages/nx/bin/init-local.ts
Outdated
| @@ -143,6 +143,20 @@ function handleAngularCLIFallbacks(workspace: WorkspaceTypeAndRoot) { | |||
| Instead, you could try an Nx Editor Plugin for a visual tool to run Nx commands. If you're using VSCode, you can use the Nx Console plugin, or if you're using WebStorm, you could use one of the available community plugins. | |||
| For more information, see https://nx.dev/using-nx/console`); | |||
| } else { | |||
| const [, , command, project, ...args] = process.argv; | |||
| logger.warn( | |||
| `${NX_PREFIX} Falling back to \`ng ${command} ${project} ${args.join( | |||
There was a problem hiding this comment.
This will probably break ng completion?
For now can we just remove deploy from this list without any warning for fallback?
There was a problem hiding this comment.
If worried about ng completion in particular, we could hide the warning for it specifically?
AgentEnder
force-pushed
the
feat/ng/warn-for-fallbacks
branch
from
ab8650d
to
ab217b4
Compare
FrozenPandaz
approved these changes
Oct 11, 2022
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 14, 2022
(cherry picked from commit 74e898d)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #