Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating new @nrwl/angular:host application adds ngcc #12386

Closed
minijus opened this issue Oct 4, 2022 · 1 comment · Fixed by #12504
Closed

Generating new @nrwl/angular:host application adds ngcc #12386

minijus opened this issue Oct 4, 2022 · 1 comment · Fixed by #12504
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@minijus
Copy link
Contributor

minijus commented Oct 4, 2022

Current Behavior

After generating new application with @nrwl/angular:host, ngcc is being add to package.json postinstall.

Expected Behavior

ngcc should not be added if the workspace does not have it.

Steps to Reproduce

Run command to generate host in clean workspace without ngcc on postinstall set.

npx nx g @nrwl/angular:host host --e2eTestRunner=none

Environment


 >  NX   Report complete - copy this into the issue template

   Node : 16.17.1
   OS   : darwin arm64
   npm  : 8.15.0
   
   nx : 14.8.2
   @nrwl/angular : 14.8.2
   @nrwl/cypress : 14.8.2
   @nrwl/detox : Not Found
   @nrwl/devkit : 14.8.2
   @nrwl/esbuild : Not Found
   @nrwl/eslint-plugin-nx : 14.8.2
   @nrwl/expo : Not Found
   @nrwl/express : Not Found
   @nrwl/jest : 14.8.2
   @nrwl/js : 14.8.2
   @nrwl/linter : 14.8.2
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : Not Found
   @nrwl/react-native : Not Found
   @nrwl/rollup : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 14.8.2
   @nrwl/web : Not Found
   @nrwl/webpack : 14.8.2
   @nrwl/workspace : 14.8.2
   typescript : 4.8.4
   ---------------------------------------
   Local workspace plugins:
   ---------------------------------------
   Community plugins:


@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants