Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): add outfile to swc compiler in non-watch mode #12345

Merged
merged 1 commit into from Oct 7, 2022

Conversation

calvinl
Copy link
Contributor

@calvinl calvinl commented Sep 30, 2022

Current Behavior

When using the node executor with a buildTarget using @nrwl/js:swc and turning off watch mode, the following error is produced:

TypeError: The "id" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:120:11)
    at Module.require (node:internal/modules/cjs/loader:998:3)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/foo/node_modules/@nrwl/js/src/executors/node/node-with-require-overrides.js:23:1)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)

Expected Behavior

The error will not show up

Related Issue(s)

#12344

Fixes #12344

@vercel
Copy link

vercel bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 7, 2022 at 3:24AM (UTC)

@nartc
Copy link
Contributor

nartc commented Oct 7, 2022

@calvinl Thank you for the PR. Can you rebase and fix the conflict?

@calvinl
Copy link
Contributor Author

calvinl commented Oct 7, 2022

@nartc done!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants