New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): remove leftovers after tslint support removal #12313
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Phillip9587! Thanks for the PR 🎉
I have some concerns with it in its current state.
The "none"
option for linting has been added to a lot of generators that previously didn't have this option at all. These generators may or may not have support for handling this correctly.
It's also not entirely in line with "just" the removal of TSLint. If possible, it would be great to keep PRs to a single concern.
With that said, would it be possible for you to remove those changes and place them in a separate PR? If there's more work than you have time available to check if those generators support "none"
as an option, feel free to create a Draft PR with those initial changes, and then I can takeover and finish it up.
Thanks again for this PR! It seems my IDE search didn't catch all "tslint" references 😞
I've added a "here" comment to all the generators so it's easy to find them 🙂
packages/react/src/generators/storybook-configuration/schema.json
Outdated
Show resolved
Hide resolved
I wanted to suggest adding support for the 'none' option in the @nrwl/linter generators directly. I will open a seperate PR tomorrow. I should have time tomorrow to cleanup this PR. |
8ab0b73
to
acd794c
Compare
acd794c
to
69cd720
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
removes tslint references and generators options missed in #12279
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #