Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): remove leftovers after tslint support removal #12313

Merged
merged 1 commit into from Sep 30, 2022

Conversation

Phillip9587
Copy link
Contributor

removes tslint references and generators options missed in #12279

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@nx-cloud-staging
Copy link

nx-cloud-staging bot commented Sep 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 69cd720. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 9:12AM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Phillip9587! Thanks for the PR 🎉

I have some concerns with it in its current state.

The "none" option for linting has been added to a lot of generators that previously didn't have this option at all. These generators may or may not have support for handling this correctly.

It's also not entirely in line with "just" the removal of TSLint. If possible, it would be great to keep PRs to a single concern.

With that said, would it be possible for you to remove those changes and place them in a separate PR? If there's more work than you have time available to check if those generators support "none" as an option, feel free to create a Draft PR with those initial changes, and then I can takeover and finish it up.

Thanks again for this PR! It seems my IDE search didn't catch all "tslint" references 😞

I've added a "here" comment to all the generators so it's easy to find them 🙂

packages/expo/src/generators/application/schema.json Outdated Show resolved Hide resolved
packages/expo/src/generators/library/schema.json Outdated Show resolved Hide resolved
packages/express/src/generators/application/schema.json Outdated Show resolved Hide resolved
packages/linter/src/executors/lint/schema.json Outdated Show resolved Hide resolved
packages/next/src/generators/application/schema.json Outdated Show resolved Hide resolved
packages/web/src/generators/application/schema.json Outdated Show resolved Hide resolved
packages/workspace/src/generators/library/schema.json Outdated Show resolved Hide resolved
packages/workspace/src/generators/new/schema.json Outdated Show resolved Hide resolved
packages/workspace/src/generators/preset/schema.json Outdated Show resolved Hide resolved
@Phillip9587
Copy link
Contributor Author

The "none" option for linting has been added to a lot of generators that previously didn't have this option at all. These generators may or may not have support for handling this correctly.

I wanted to suggest adding support for the 'none' option in the @nrwl/linter generators directly. I will open a seperate PR tomorrow.

I should have time tomorrow to cleanup this PR.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants