Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): Fixed script optimization not working for node target #12221

Merged
merged 1 commit into from Nov 7, 2022
Merged

fix(webpack): Fixed script optimization not working for node target #12221

merged 1 commit into from Nov 7, 2022

Conversation

TriPSs
Copy link
Contributor

@TriPSs TriPSs commented Sep 23, 2022

Current Behavior

TerserPlugin is not being applied causing optimized code not to run correctly.

Expected Behavior

That the TerserPlugin is applied when optimisation is enabled.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Sep 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 23, 2022 at 10:35PM (UTC)

@msuhov
Copy link

msuhov commented Oct 13, 2022

Any updates on this?

@abonifacio
Copy link

Fixes #12706

@TriPSs
Copy link
Contributor Author

TriPSs commented Oct 28, 2022

Can someone (@jaysoo ?) check/merge this PR? This is preventing me from upgrading to the latest nx.

@TriPSs
Copy link
Contributor Author

TriPSs commented Nov 3, 2022

@jaysoo any update?

@abonifacio
Copy link

Hello, can someone take a look please? @jaysoo @barbados-clemens @bcabanes @FrozenPandaz

Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaysoo jaysoo merged commit a690dbd into nrwl:master Nov 7, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants