Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): switch to using jasmine-marbles for certain symbols #11896

Merged
merged 1 commit into from Sep 28, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 6, 2022

Current Behavior

We currently re-export hot, cold, getTestScheduler and time from jasmine-marbles at @nrwl/angular/testing. This is deprecated.

Expected Behavior

We should encourage users to use jasmine-marbles directly.
Remove the deprecated re-exports
Include a migration for people currently using these symbols via @nrwl/angular/testing

@Coly010 Coly010 self-assigned this Sep 6, 2022
@vercel
Copy link

vercel bot commented Sep 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 21, 2022 at 11:22AM (UTC)

@Coly010 Coly010 marked this pull request as draft September 6, 2022 15:25
@Coly010 Coly010 marked this pull request as ready for review September 20, 2022 14:23
@Coly010 Coly010 added the target: next major version To be merged for the next major version release label Sep 20, 2022
@Coly010 Coly010 force-pushed the angular/switch-to-jasmine-marbles branch from 0b4746e to 99afffd Compare September 21, 2022 10:18
@Coly010 Coly010 force-pushed the angular/switch-to-jasmine-marbles branch from 99afffd to b779ef5 Compare September 21, 2022 11:22
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit 3dc72f0 into nrwl:master Sep 28, 2022
@Coly010 Coly010 deleted the angular/switch-to-jasmine-marbles branch September 28, 2022 14:54
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: next major version To be merged for the next major version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants