New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): switch to using jasmine-marbles for certain symbols #11896
Merged
Coly010
merged 1 commit into
nrwl:master
from
Coly010:angular/switch-to-jasmine-marbles
Sep 28, 2022
Merged
fix(angular): switch to using jasmine-marbles for certain symbols #11896
Coly010
merged 1 commit into
nrwl:master
from
Coly010:angular/switch-to-jasmine-marbles
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
added
the
target: next major version
To be merged for the next major version release
label
Sep 20, 2022
packages/angular/src/migrations/update-15-0-0/switch-to-jasmine-marbles.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
angular/switch-to-jasmine-marbles
branch
from
September 21, 2022 10:18
0b4746e
to
99afffd
Compare
Coly010
force-pushed
the
angular/switch-to-jasmine-marbles
branch
from
September 21, 2022 11:22
99afffd
to
b779ef5
Compare
leosvelperez
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently re-export
hot
,cold
,getTestScheduler
andtime
from jasmine-marbles at@nrwl/angular/testing
. This is deprecated.Expected Behavior
We should encourage users to use
jasmine-marbles
directly.Remove the deprecated re-exports
Include a migration for people currently using these symbols via
@nrwl/angular/testing