Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): close typescript watch program on SIGINT/SIGTERM #11722

Merged

Conversation

skrtheboss
Copy link
Contributor

Close typescript watch program and complete iterator to ensure program can exit.

Current Behavior

Runnig @nrwl/js:tsc compiler with the --watch=true option, causes underlying process to run forewer.

Expected Behavior

TSC process should terminate as soon as executor is terminated.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Aug 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 11, 2022 at 7:38AM (UTC)

@skrtheboss skrtheboss force-pushed the fix/close-typescript-program-on-sigint-sigterm branch from 156c698 to fdccfef Compare September 13, 2022 09:22
@nartc nartc force-pushed the fix/close-typescript-program-on-sigint-sigterm branch 2 times, most recently from 4c27e3a to 7a42caa Compare September 27, 2022 11:00
@nartc
Copy link
Contributor

nartc commented Oct 11, 2022

Hi @skrtheboss, sorry for the late response but can you rebase and fix the conflict?

@skrtheboss skrtheboss force-pushed the fix/close-typescript-program-on-sigint-sigterm branch from 7a42caa to 7322652 Compare October 11, 2022 07:05
@skrtheboss
Copy link
Contributor Author

Hi @nartc, no worries.
I have rebased the pull request.

Close typescript watch program and complete iterator to ensure program can exit.
@skrtheboss skrtheboss force-pushed the fix/close-typescript-program-on-sigint-sigterm branch from 7322652 to b739c9f Compare October 11, 2022 07:37
@nartc nartc merged commit f1a24d7 into nrwl:master Oct 11, 2022
@skrtheboss skrtheboss deleted the fix/close-typescript-program-on-sigint-sigterm branch October 11, 2022 17:01
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants