New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): close typescript watch program on SIGINT/SIGTERM #11722
Merged
nartc
merged 1 commit into
nrwl:master
from
skrtheboss:fix/close-typescript-program-on-sigint-sigterm
Oct 11, 2022
Merged
fix(js): close typescript watch program on SIGINT/SIGTERM #11722
nartc
merged 1 commit into
nrwl:master
from
skrtheboss:fix/close-typescript-program-on-sigint-sigterm
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
skrtheboss
force-pushed
the
fix/close-typescript-program-on-sigint-sigterm
branch
from
September 13, 2022 09:22
156c698
to
fdccfef
Compare
nartc
force-pushed
the
fix/close-typescript-program-on-sigint-sigterm
branch
2 times, most recently
from
September 27, 2022 11:00
4c27e3a
to
7a42caa
Compare
Hi @skrtheboss, sorry for the late response but can you rebase and fix the conflict? |
skrtheboss
force-pushed
the
fix/close-typescript-program-on-sigint-sigterm
branch
from
October 11, 2022 07:05
7a42caa
to
7322652
Compare
Hi @nartc, no worries. |
Close typescript watch program and complete iterator to ensure program can exit.
skrtheboss
force-pushed
the
fix/close-typescript-program-on-sigint-sigterm
branch
from
October 11, 2022 07:37
7322652
to
b739c9f
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close typescript watch program and complete iterator to ensure program can exit.
Current Behavior
Runnig @nrwl/js:tsc compiler with the --watch=true option, causes underlying process to run forewer.
Expected Behavior
TSC process should terminate as soon as executor is terminated.
Related Issue(s)
Fixes #