Add swc as an option to use with node/nestjs builder

[tonivj5]

• I'd be willing to implement this feature (contributing guide)

Description

As swc-project/swc#3459 has fixed the use of legacy-decorators, it'd awesome to be able of use swc as compiler/bundler to reduce typescript compilation time 🚀

Motivation

Reduce time of tsc.

Suggested Implementation

swc is used with @nrwl/js and others, use it with @nrwl/node (nestjs) too

Alternate Implementations

esbuild doesn't support legacy decorators emitDecoratorMetadata 😢

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

[tonivj5]

Up

[kdawgwilk]

Looks like its coming to NestCLI so it would be great for Nx to also provide it as an option https://twitter.com/kammysliwiec/status/1664192006019506178?s=20

[arivera-xealth]

bump

[drackp2m]

I think many of us would love to see this.

[AdhamMoussa]

Up

[kdawgwilk]

NestJS CLI shipped this in v10 https://trilon.io/blog/nestjs-10-is-now-available#nestjs-%EF%B8%8F-swc

[ggagosh]

Given that the latest version of Nx seems to be slowing down the NestJS development process, I was wondering if there are any plans to integrate SWC to potentially improve performance. 🤔

[michaeljauk]

Is there anyone willing to work on this?

[DavidFencl]

+1 on this. Adding support for SWC would be great for NestJs apps. I've managed to get SWC working with NestJs, but compilation fails on NX library imports.

[om-mahato]

+1

[thenglong]

+1. This will make development experience so much better.

[itspers]

Is it possible to use this nest start -b swc instead of default nx builder?
This nx has interesting curve: first when you start using it - it feels 'right', but then with every update more and more problems occur with angular, react, nest.. to the point where im now sure maintaining just 10 stanalone apps would be much simpler.

[mhdismail]

Up.

[dragomir-parvanov-riskmethods]

@itspers

I thought I made it working with nest start -b swc, but when I tried to import an nx generated library, the paths were not compiled at all

[DobroslavR]

@c0dewriter can you make public repo with this?

[wilson208]

{
  "$schema": "https://json.schemastore.org/swcrc",
  "sourceMaps": true,
  "module": {
    "type": "commonjs",       // <---- Important
    "strict": true,
    "strictMode": true
  },
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "decorators": true,
      "dynamicImport": true
    },
    "transform": {
      "legacyDecorator": true,
      "decoratorMetadata": true
    }
  },
  "minify": true
}

@c0dewriter thanks for these snippets. I can compile a new standalone NestJS app in NX, however imports from libs aren't working for me with this error at build time

 File 'libs/nest-stripe/index.ts' is not under 'rootDir' 'apps/api'. 'rootDir' is expected to contain all source files

[pf1gura]

This is the main issue here and probably why it takes so long. Executor do more stuff than just wrapping underlying tech (like swc). It also has to rewrite your imports depending on the command you run. serve has to read all your sources directly (most likely TypeScript files) from packages/libs directory. In build mode it uses compiled source code from dist. In order to do that it needs to create dynamic configuration files depending on the command and do few other things to wire everything.

If you want all the nice things that nx gives you for monorepo management you have to accept that you won't always be able to use latest and greatest from the framework that nx wraps.

[wilson208]

@pf1gura thanks for your insight. Given the solution above uses the existing '@nx/js:swc' executor I made an assumption that this executor would already handle imports from libs. @c0dewriter posted a potential solution, I tried it and gave feedback, I'm just keen for a solution because my NestJS build times have been very slow after the release of v10 and the nx monorepo I work with day to day has 6 different NestJS applications and the DX isn't great right now.

[pf1gura]

If I recall correctly existing swc executor is for libraries only. You can use it in your shared TypeScript libraries to speed up library build times but final build of your application still has to go through node executor (which does not use swc)

[quesurifn]

@wilson208 I'm actually seeing the same rootDir bug. Have you found a fix yet?

[mandarini]

@quesurifn @wilson208 and anyone else, is it possible that your build target names (of two interdependent libs) are different? This bug can appear if you are importing one buildable lib into the other, and the build target names are different.

related: #11289

For anyone having that error, solution: #17798 (comment)

[ggagosh]

@quesurifn @wilson208 and anyone else, is it possible that your build target names (of two interdependent libs) are different? This bug can appear if you are importing one buildable lib into the other, and the build target names are different.

related: #11289

For anyone having that error, solution: #17798 (comment)

I'm currently working on integrating SWC into my NestJS application using NX. In my setup, I have shared libraries that are non-buildable, so the solution you mentioned doesn't seem applicable in my case.

Is there an alternative approach or workaround that could make this integration possible?

[leosvelperez]

There are many things being discussed in this thread. Let's try to keep it focused on the original request (supporting swc).

Anyone with the 'rootDir' is expected to contain all source files error, please see #11289 (comment). You can follow the conversation over there.

[quesurifn]

@mandarini Indeed that was the issue. I encountered this with TS now. For some reason TS didn't trigger the same error until I did a complete refactor but I indeed did have circular dependencies that were two buildable libs referencing each other. The fix was to put them into one lib and then break them up with ts paths so semantically, at least, there is some differentiation.

[quesurifn]

@ggagosh I would try looking even if they are not buildable. Also if you're using TS they are indeed buildable. I fixed mine from putting libs that imported each other into the same lib.

[kdawgwilk]

I also used the https://github.com/pahen/madge tool to help find some circular deps issues that was blocking swc from being able to compile my projects

[SahilMahadwar]

+1

[sasha-flow]

SWC support for NestJS apps is still required

[gperdomor]

Any plan to support this in nx? :(