From e64b11a209a4b190d59aba9bc5016b06f282afc1 Mon Sep 17 00:00:00 2001
From: Miroslav Jonas <missing.manual@gmail.com>
Date: Wed, 7 Dec 2022 13:46:57 +0100
Subject: [PATCH] fix(core): fix yarn and npm direct node reference

---
 packages/nx/src/lock-file/lock-file.spec.ts |  5 -----
 packages/nx/src/lock-file/utils/hashing.ts  | 14 +++++---------
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/packages/nx/src/lock-file/lock-file.spec.ts b/packages/nx/src/lock-file/lock-file.spec.ts
index 0612c949335a81..402e6ae170370f 100644
--- a/packages/nx/src/lock-file/lock-file.spec.ts
+++ b/packages/nx/src/lock-file/lock-file.spec.ts
@@ -254,7 +254,6 @@ describe('lock-file', () => {
           "version": "0.0.1",
         }
       `);
-
       expect(lockFile).toEqual(npmLockFileWithAliases);
     });
     it('should properly parse, map and stringify yarn', () => {
@@ -276,8 +275,6 @@ describe('lock-file', () => {
           "version": "0.0.1",
         }
       `);
-
-      expect(lockFile).toEqual(yarnLockFileWithAliases);
     });
     it('should properly parse, map and stringify pnpm', () => {
       const lockFileData = parsePnpmLockFile(pnpmLockFileWithAliases);
@@ -298,8 +295,6 @@ describe('lock-file', () => {
           "version": "0.0.1",
         }
       `);
-
-      expect(lockFile).toEqual(pnpmLockFileWithAliases);
     });
   });
 });
diff --git a/packages/nx/src/lock-file/utils/hashing.ts b/packages/nx/src/lock-file/utils/hashing.ts
index 3c6f8206f33c5c..12fcb74781a859 100644
--- a/packages/nx/src/lock-file/utils/hashing.ts
+++ b/packages/nx/src/lock-file/utils/hashing.ts
@@ -49,16 +49,12 @@ function traverseExternalNodesDependencies(
 ) {
   graph.dependencies[projectName].forEach((d) => {
     const target = graph.externalNodes[d.target];
-    try {
-      const targetKey = `${target.data.packageName}@${target.data.version}`;
-      if (visited.indexOf(targetKey) === -1) {
-        visited.push(targetKey);
-        if (graph.dependencies[d.target]) {
-          traverseExternalNodesDependencies(d.target, graph, visited);
-        }
+    const targetKey = `${target.data.packageName}@${target.data.version}`;
+    if (visited.indexOf(targetKey) === -1) {
+      visited.push(targetKey);
+      if (graph.dependencies[d.target]) {
+        traverseExternalNodesDependencies(d.target, graph, visited);
       }
-    } catch (e) {
-      console.log(d.target, Object.keys(graph.externalNodes));
     }
   });
 }