Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use ? instead of try! #60

Merged
merged 1 commit into from Mar 31, 2021
Merged

refactor: use ? instead of try! #60

merged 1 commit into from Mar 31, 2021

Conversation

toku-sa-n
Copy link
Contributor

Not all try!s were removed in the previous PR.

@toku-sa-n
refactor: use ? instead of try!
3fb82e6 
Not all `try!`s were removed in the previous PR.
nrc
nrc approved these changes Mar 31, 2021
View reviewed changes
Copy link
Owner

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nrc nrc merged commit 3b7439c into nrc:master Mar 31, 2021
@toku-sa-n toku-sa-n deleted the remove_try branch March 31, 2021 03:31
@toku-sa-n toku-sa-n restored the remove_try branch April 1, 2021 03:03
@toku-sa-n toku-sa-n deleted the remove_try branch April 1, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toku-sa-n @nrc