Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set package.json version from release please #192

Merged
merged 1 commit into from Sep 14, 2022

Conversation

lukekarrys
Copy link
Member

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner September 13, 2022 22:39
@wraithgar
Copy link
Member

What bug is this fixing and how easy would it be to test?

@lukekarrys
Copy link
Member Author

Currently when run with workspaces, release-please is not bumping package.json#version (npm/cli@683973c). This is a regression from #183 and puts the tree into an invalid state so npm i will fail.

It's not easy to test without mocking a bunch of stuff due to how release-please itself it setup. This class extends a release-please class which makes a lot of assumptions about data structures. Originally I avoided testing since it was mostly mocks, but this bug points to us needing tests here so mocks might be ok in this case.

@lukekarrys lukekarrys force-pushed the lk/release-please-pkg-json-version branch from d2d7c88 to 940e0e3 Compare September 14, 2022 19:53
@lukekarrys
Copy link
Member Author

Ended up adding a test for it with some mocked release-please data structures. It will give us more confidence in the future as we keep up with release-please updates that this is still working.

@lukekarrys lukekarrys merged commit 6bc355a into main Sep 14, 2022
@lukekarrys lukekarrys deleted the lk/release-please-pkg-json-version branch September 14, 2022 20:10
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants