Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release please fixes #178

Closed
lukekarrys opened this issue Aug 31, 2022 · 0 comments · Fixed by #179
Closed

Release please fixes #178

lukekarrys opened this issue Aug 31, 2022 · 0 comments · Fixed by #179

Comments

@lukekarrys
Copy link
Member

lukekarrys commented Aug 31, 2022 •
edited

Fall out from automated CLI release: npm/cli#5447

  • Workspace deps should be linked to latest tag comparison but that doesnt work for packages named differently than their scope eg @npmcli/arborist
  • workspace deps plugin should rewrite changelog too
  • AUTHORS script gets deleted due to insufficient git fetch depth
  • Remove prepublishOnly to push tags
@lukekarrys lukekarrys changed the title fix: release please workspace deps link packages with scopes Release please fixes Aug 31, 2022
lukekarrys added a commit that referenced this issue Sep 1, 2022
@lukekarrys
fix: update a few release nits after trying it on the cli
64df66e 
Closes #178
@lukekarrys lukekarrys mentioned this issue Sep 1, 2022
Merged
lukekarrys added a commit that referenced this issue Sep 1, 2022
@lukekarrys
fix: update a few release nits after trying it on the cli
c224c7c 
Closes #178
lukekarrys added a commit that referenced this issue Sep 1, 2022
@lukekarrys
fix: update a few release nits after trying it on the cli
7331d16 
- Correctly link workspace dep changelog entry to compare link even when
  release component is different than the package name
- Update changelog entry also when rewriting workspaces deps
- Clone repo during release process with `fetch-depth: 0` so we can have
  full commit history to build `AUTHORS` files
- Removes `preversion`, `postversion`, and `prepublishOnly` scripts now
  that all tagging happens via `release-please`

Closes #178
lukekarrys added a commit that referenced this issue Sep 1, 2022
@lukekarrys
fix: update a few release nits after trying it on the cli
a26705f 
- Correctly link workspace dep changelog entry to release even when
  release component is different than the package name
- Update changelog entry also when rewriting workspaces deps
- Clone repo during release process with `fetch-depth: 0` so we can have
  full commit history to build `AUTHORS` files
- Removes `preversion`, `postversion`, and `prepublishOnly` scripts now
  that all tagging happens via `release-please`
- Correctly version root when going from prerelease -> release

Closes #178
lukekarrys added a commit that referenced this issue Sep 1, 2022
@lukekarrys
fix: update a few release nits after trying it on the cli (#179)
70782b3 
- Correctly link workspace dep changelog entry to release even when
  release component is different than the package name
- Update changelog entry also when rewriting workspaces deps
- Clone repo during release process with `fetch-depth: 0` so we can have
  full commit history to build `AUTHORS` files
- Removes `preversion`, `postversion`, and `prepublishOnly` scripts now
  that all tagging happens via `release-please`
- Correctly version root when going from prerelease -> release

Closes #178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update a few release nits after trying it on the cli npm/template-oss
1 participant
@lukekarrys