-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RRFC] Set version. Don't tag per default. #659
Comments
How is it more error prone? An undesired tag can simply be deleted, but a missing tag might be harder to reconstruct later. |
Well, there are several reasons or cases. At first we have to say that this method creates a commit and tag. And in my case I accidentally created this tags and commits. I didn't know that. I wrote and tested a CI script which executed |
Right - so in your case, the worst damage was some extra commits and tags, in a version control system that lets you get rid of them without a trace. If the change you're requesting happens, the worst damage is that information is irretrievably lost forever. It seems clear to me which default is safest. |
Suggestion: Don't create Git tags by default. Invert the logic of
--no-git-tag-version
. The dev should add option like--git-tag
or just--tag
to automatically create a tag. In my opinion we (e.g. CI) should have full control when and how to commit and tag. It's more error-prone to tag by default.https://docs.npmjs.com/cli/commands/npm-version
The text was updated successfully, but these errors were encountered: