fix(refactor): update deps, lint, test coverage #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
commented
Jul 2, 2021
| "set-blocking": "~2.0.0" | ||
| "are-we-there-yet": "^1.1.5", | ||
| "console-control-strings": "^1.1.0", | ||
| "gauge": "^3.0.0", |
There was a problem hiding this comment.
The change from 2 to 3 was dropping npm 8 and 6 support.
Also fixes a bug in enableProgress that was enabling the gauge even if the log was paused. Coverage for branches is downgraded to 95 so that CI is green. This is a compromise to get us up to date in dependencies. The coverage is MORE than it was before, and we can keep making it better but I don't think it should block our updating of dependencies.
wraithgar
force-pushed
the
gar/dependencies
branch
from
7c6222f
to
4c7d851
Compare
wraithgar
commented
Jul 20, 2021
| this.progressEnabled = true | ||
| this.tracker.on('change', this.showProgress) | ||
| if (this._pause) return | ||
| if (this._paused) |
There was a problem hiding this comment.
This is the bugfix. It's this._paused not this._pause
nlf
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a bug in enableProgress that was enabling the gauge even if
the log was paused.
Coverage for branches is downgraded to 95 so that CI is green. This is a
compromise to get us up to date in dependencies. The coverage is MORE
than it was before, and we can keep making it better but I don't think
it should block our updating of dependencies.