Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Package tarballs are included by default #174

Open
1 task done
remcohaszing opened this issue Aug 21, 2023 · 1 comment
Open
1 task done

[BUG] Package tarballs are included by default #174

remcohaszing opened this issue Aug 21, 2023 · 1 comment
Labels
Bug thing that needs fixing Needs Triage needs an initial review

Comments

@remcohaszing
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Running npm pack includes the previous result of npm pack by default.

Expected Behavior

The result of npm pack is excluded. This probably means all .tgz files should be excluded. Users can choose to exclude it, but many don’t know about it.

Steps To Reproduce

  1. Clone a repo that doesn’t use the files fields in package.json and doesn’t use .npmignore to exclude .tgz files. For example:
    git@github.com:postcss/postcss.git
    cd postcss
  2. Packing produces the expected results:
    npm pack
  3. Packing again includes the previously built tarball
    npm pack

Environment

  • npm: v20.5.1
  • Node: 9.8.1
  • OS: Pop!_OS 22.04
  • platform: System76 Oryx Pro
@remcohaszing remcohaszing added Bug thing that needs fixing Needs Triage needs an initial review labels Aug 21, 2023
@ljharb
Copy link

ljharb commented Aug 21, 2023

This seems expected to me; most people never run npm pack at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs an initial review
Projects
None yet
Development

No branches or pull requests

2 participants